Repository navigation
Mark vendored agentdb private; skip claude-review when its token is unset - #32
Merged
Merged
Conversation
…nset - apps/agentdb/package.json declared "name": "agentdb" without "private": true, so an npm publish from that directory would collide with the real agentdb package (ruvnet/agentdb, 3.10.0). Keep the name, add the private flag. - claude-code-review failed on every PR because CLAUDE_CODE_OAUTH_TOKEN is empty. A gate job now reads the secret through env and exposes only a has_token output; claude-review runs only when it is true. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/agentdb/package.jsondeclared"name": "agentdb"and was not private.npm view agentdbshows 3.10.0 fromgit+https://github.com/ruvnet/agentdb.git(the real package), so a publish from this vendored copy (2.0.0-alpha.2.20) would collide with it. This adds"private": trueand keeps the name. Nothing in the repo publishesapps/agentdb.claude_code_oauth_token: ""becauseCLAUDE_CODE_OAUTH_TOKENis unset (see run 42250100918). Secrets can't be read in a job-levelif, so a newcheck-tokenjob reads the secret throughenvand outputs onlyhas_token.claude-reviewnow hasneeds: check-tokenandif: needs.check-token.outputs.has_token == 'true', so it is skipped instead of failing. The workflow stays in place, and once the secret is added the review runs again with no further change.Other manifests checked (no change)
private: trueprivate: trueprivate: truePublishes nothing.
🤖 Generated with claude-flow