Skip to content

Mark vendored agentdb private; skip claude-review when its token is unset - #32

Merged
ruvnet merged 1 commit into
mainfrom
fix/agentdb-private-claude-review-gate
Nov 11, 2026
Merged

ruvnet merged 1 commit into
mainfrom
fix/agentdb-private-claude-review-gate

Conversation

@ruvnet

@ruvnet ruvnet commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Name collision: apps/agentdb/package.json declared "name": "agentdb" and was not private. npm view agentdb shows 3.10.0 from git+https://github.com/ruvnet/agentdb.git (the real package), so a publish from this vendored copy (2.0.0-alpha.2.20) would collide with it. This adds "private": true and keeps the name. Nothing in the repo publishes apps/agentdb.
  • claude-review always fails: the job runs with claude_code_oauth_token: "" because CLAUDE_CODE_OAUTH_TOKEN is unset (see run 42250100918). Secrets can't be read in a job-level if, so a new check-token job reads the secret through env and outputs only has_token. claude-review now has needs: check-token and if: needs.check-token.outputs.has_token == 'true', so it is skipped instead of failing. The workflow stays in place, and once the secret is added the review runs again with no further change.

Other manifests checked (no change)

Manifest Name npm
apps/agentic-flow agentic-flow already private: true
apps/agentic-synth @ruvector/agentic-synth already private: true
apps/media-discovery @arw/media-discovery already private: true
apps/cli agentics-hackathon published from this repo (repository = agenticsorg/hackathon-tv5), so it stays publishable
apps/arw-chrome-extension arw-chrome-extension E404, not published
apps/agentic-flow/wasm/quic agentic-flow-quic E404, not published
apps/agentic-flow/wasm/reasoningbank reasoningbank-wasm E404, not published

Publishes nothing.

🤖 Generated with claude-flow

…nset

- apps/agentdb/package.json declared "name": "agentdb" without
  "private": true, so an npm publish from that directory would collide
  with the real agentdb package (ruvnet/agentdb, 3.10.0). Keep the name,
  add the private flag.
- claude-code-review failed on every PR because CLAUDE_CODE_OAUTH_TOKEN
  is empty. A gate job now reads the secret through env and exposes only
  a has_token output; claude-review runs only when it is true.

Co-Authored-By: claude-flow <ruv@ruv.net>
@ruvnet
ruvnet merged commit f48cd48 into main Nov 11, 2026
2 checks passed
@ruvnet
ruvnet deleted the fix/agentdb-private-claude-review-gate branch November 11, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant